nfsd: stricter decoding of write-like NFSv2/v3 ops
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 21 Apr 2017 19:26:30 +0000 (15:26 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 May 2017 05:46:02 +0000 (07:46 +0200)
commitda1ce38aaac7f08d319b4b76130aa4fd27c4489f
tree26946370f834a2cc6f05c764f5c8e974354298e4
parent35e13333c217f0255a1e657ce075f0f72bc6383c
nfsd: stricter decoding of write-like NFSv2/v3 ops

commit 13bf9fbff0e5e099e2b6f003a0ab8ae145436309 upstream.

The NFSv2/v3 code does not systematically check whether we decode past
the end of the buffer.  This generally appears to be harmless, but there
are a few places where we do arithmetic on the pointers involved and
don't account for the possibility that a length could be negative.  Add
checks to catch these.

Reported-by: Tuomas Haanpää <thaan@synopsys.com>
Reported-by: Ari Kauppi <ari@synopsys.com>
Reviewed-by: NeilBrown <neilb@suse.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfsd/nfs3xdr.c
fs/nfsd/nfsxdr.c