mmc_block: fix queue cleanup
authorAdrian Hunter <adrian.hunter@nokia.com>
Fri, 8 Jan 2010 22:43:00 +0000 (14:43 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 18 Jan 2010 18:19:36 +0000 (10:19 -0800)
commite0abcea649db45223c7df49df5db04dc1aa3a271
tree3c2c808ed4606d802108676aad9cbff968e9721b
parent0c74f45acfacc220adfa9e035ffeb3d5e8f9f0d8
mmc_block: fix queue cleanup

commit 5fa83ce284a4b7cd9dcfadd01500b0ed4ab9b740 upstream.

The main bug was that 'blk_cleanup_queue()' was called while the block
device could still be in use, for example, because the card was removed
while files were still open.

In addition, to be sure that 'mmc_request()' will get called for all new
requests (so it can error them out), the queue is emptied during cleanup.
This is done after the worker thread is stopped to avoid racing with it.

Finally, it is not a device error for this to be happening, so quiet the
(sometimes very many) error messages.

Signed-off-by: Adrian Hunter <adrian.hunter@nokia.com>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/mmc/card/block.c
drivers/mmc/card/queue.c