projects / folly.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3ac402b) | patch
bug fix when rallocm fails
authorYasser Ganjisaffar <yasserg@fb.com>
Mon, 27 Jan 2014 18:36:22 +0000 (10:36 -0800)
committerSara Golemon <sgolemon@fb.com>
Thu, 6 Feb 2014 19:50:13 +0000 (11:50 -0800)
commite0b08360d75ad0a188116358786fcb527786498f
treec3f136b0c4ff1318e89154f3bec6ca346872d984tree | snapshot
parent3ac402b1e087ac8e3abe24b5f0a19f74fb3ddd11commit | diff
bug fix when rallocm fails

Summary:
rallocm sets the value of the second argument even if it has failed to allocate the requested size:
https://github.com/jemalloc/jemalloc/blob/898960247a8b2e6534738b7a3a244855f379faf9/src/jemalloc.c#L1903-L1906

As a result newAllocatedCapacity was being set to a value less than the original value and the logic was broken.

Test Plan: unit tests pass and my code which was crashing before now works!

Reviewed By: soren@fb.com

FB internal diff: D1144314
folly/io/IOBuf.cpp diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.