Do not make -pass-remarks additive.
authorDiego Novillo <dnovillo@google.com>
Tue, 6 May 2014 19:14:00 +0000 (19:14 +0000)
committerDiego Novillo <dnovillo@google.com>
Tue, 6 May 2014 19:14:00 +0000 (19:14 +0000)
commite3e870facee9f1fcf5b19f15a3deb78b582fb37e
tree9dcdfd8bf30359bfa81748787b1c2480cceeef0c
parent2c06cd8612adc919da3c5c5b02d2bb05487dd5f9
Do not make -pass-remarks additive.

Summary:
When I initially introduced -pass-remarks, I thought it would be a
neat idea to make it additive. So, if one used it as:

$ llc -pass-remarks=inliner --pass-remarks=loop.*

the compiler would build the regular expression '(inliner)|(loop.*)'.

The more I think about it, the more I regret it. This is not how
other flags work. The standard semantics are right-to-left overrides.

This is how clang interprets -Rpass. And I think the two should be
compatible in this respect.

Reviewers: qcolombet

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D3614

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@208122 91177308-0d34-0410-b5e6-96231b3b80d8
lib/IR/LLVMContextImpl.cpp
test/Other/optimization-remarks-inline.ll