efi_pstore: Avoid deadlock in non-blocking paths
authorSeiji Aguchi <seiji.aguchi@hds.com>
Fri, 11 Jan 2013 18:10:05 +0000 (18:10 +0000)
committerTony Luck <tony.luck@intel.com>
Fri, 11 Jan 2013 18:21:56 +0000 (10:21 -0800)
commite59310adf5eebce108f78b6c47bb330aae2e1666
tree755e6f7348fd37094a856595f4ab33ffc5635ce2
parent9f244e9cfd70c7c0f82d3c92ce772ab2a92d9f64
efi_pstore: Avoid deadlock in non-blocking paths

[Issue]

There is a scenario which efi_pstore may hang up:

 - cpuA grabs efivars->lock
 - cpuB panics and calls smp_send_stop
 - smp_send_stop sends IRQ to cpuA
 - after 1 second, cpuB gives up on cpuA and sends an NMI instead
 - cpuA is now in an NMI handler while still holding efivars->lock
 - cpuB is deadlocked

This case may happen if a firmware has a bug and
cpuA is stuck talking with it.

[Solution]

This patch changes a spin_lock to a spin_trylock in non-blocking paths.
and if the spin_lock has already taken by another cpu,
it returns without accessing to a firmware to avoid the deadlock.

Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
Acked-by: Don Zickus <dzickus@redhat.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
drivers/firmware/efivars.c