virtio_balloon: leak_balloon(): only tell host if we got pages deflated
authorLuiz Capitulino <lcapitulino@redhat.com>
Tue, 2 Jul 2013 06:05:13 +0000 (15:35 +0930)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jul 2013 21:07:31 +0000 (14:07 -0700)
commitebfc049ce8e32b5ff6bf6fec74775ac021769f37
treeae447ceae1642cf9bc5649082b2b448cb6ae0740
parent0531603e3a0dbb7c36f2b37833add0e73b8c0c5f
virtio_balloon: leak_balloon(): only tell host if we got pages deflated

commit 8c6bab4f3874d31804a00782c48a8f244a0d3cc0 upstream.

balloon_page_dequeue() can return NULL.  If it does for the first page
being freed then leak_balloon() will create a scatter list with len=0.
Which in turn seems to generate an invalid virtio request.

I didn't get this in practice, I found it by code review.  On the other
hand, such an invalid virtio request will cause errors in QEMU and
fill_balloon() also performs the same check implemented by this commit.

This bug was introduced in e2250429.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Acked-by: Rafael Aquini <aquini@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/virtio/virtio_balloon.c