ext4: don't trash state flags in EXT4_IOC_SETFLAGS
authorTheodore Ts'o <tytso@mit.edu>
Fri, 1 Jun 2012 03:46:01 +0000 (23:46 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 9 Jun 2012 15:33:04 +0000 (00:33 +0900)
commiteeb7cb57cf619ae9ab8210b21b49820ed40a472f
treeaef576ca6a445f87ba08089b2f06774dc6eee200
parent801bdd926b6229da233f6db25770c9e817f98d4e
ext4: don't trash state flags in EXT4_IOC_SETFLAGS

commit 79906964a187c405db72a3abc60eb9b50d804fbc upstream.

In commit 353eb83c we removed i_state_flags with 64-bit longs, But
when handling the EXT4_IOC_SETFLAGS ioctl, we replace i_flags
directly, which trashes the state flags which are stored in the high
32-bits of i_flags on 64-bit platforms.  So use the the
ext4_{set,clear}_inode_flags() functions which use atomic bit
manipulation functions instead.

Reported-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/ioctl.c