projects / folly.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1673619) | patch
folly Symbolizer: fix destruction-order fiasco problem
authorSteve O'Brien <steveo@fb.com>
Wed, 30 Sep 2015 21:06:22 +0000 (14:06 -0700)
committerfacebook-github-bot-1 <folly-bot@fb.com>
Wed, 30 Sep 2015 21:20:16 +0000 (14:20 -0700)
commitf04e4550e868b4b6aaae011caefc05347520b676
tree70e17d043fa3fce36d7e923148014b1c43bc400btree | snapshot
parent1673619a96338ad2bbf953e85c2d539867735352commit | diff
folly Symbolizer: fix destruction-order fiasco problem

Summary: On a (broken) unit test there is a bad `CHECK` during destruction time.  This triggers an ABRT, goes through the signal handler, and in the process ends up doing a use-after-free.

Moved some globals inside the functions in which they are used (w/ little duplication, as they are used in one place, mostly).

Reviewed By: @luciang, @meyering

Differential Revision: D2494046
folly/experimental/symbolizer/Symbolizer.cpp diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.