projects / folly.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: aa62e6f) | patch
Fix hardware crc32 under MSVC
authorChristopher Dykes <cdykes@fb.com>
Tue, 19 Sep 2017 02:03:12 +0000 (19:03 -0700)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Tue, 19 Sep 2017 02:05:29 +0000 (19:05 -0700)
commitf3bce4241d7d3f1a80cc9a5391e7012af5f67f5a
treeffda6c8cac7d43404b61bf37a9e1f319570006f6tree | snapshot
parentaa62e6f3ba01d7332f92ffe91694a43577234d62commit | diff
Fix hardware crc32 under MSVC

Summary: It was horribly broken in multiple ways. It didn't support input > 4gb on Windows, was truncating the entire table to chars, and simply couldn't be compiled because it was exceeding MSVC's max macro instantion depth of 255.

Reviewed By: yfeldblum

Differential Revision: D5827332

fbshipit-source-id: b08268c88db10c607b27231689b3ee3ec7553c1f
folly/detail/Crc32cDetail.cpp diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.