Change NotificationQueue assert -> CHECK
authorRanjeeth Dasineni <ranjeeth@fb.com>
Sat, 17 Oct 2015 00:22:49 +0000 (17:22 -0700)
committerfacebook-github-bot-1 <folly-bot@fb.com>
Sat, 17 Oct 2015 01:20:18 +0000 (18:20 -0700)
commitf640f4bb2f19e57971e1162955ae9c7cae38973f
tree0a91c7af09538bfbb7f0c7bb6f45327f03d75e73
parentb4c40ee9da8183d78bf5506562e9c241f659f71b
Change NotificationQueue assert -> CHECK

Summary: If the eventFd goes bad, NotificationQueue consumers can cause their event loop to spin indefinitely.  If libevent gets POLLERR on the fd, it calls handlerReady, which triggers a read.  The read will fail, but the callback is never uninstalled.  I'm not sure it would be easy to recover gracefully from this, so crash hard instead.

Reviewed By: yfeldblum, pgriess

Differential Revision: D2550270

fb-gh-sync-id: c9575fbda778b3625da6d9db6b0542b8263f230a
folly/io/async/NotificationQueue.h