powerpc/pseries: Correct string length in pseries_of_derive_parent()
authorNathan Fontenot <nfont@linux.vnet.ibm.com>
Tue, 27 Oct 2015 15:46:47 +0000 (10:46 -0500)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 28 Oct 2015 03:08:18 +0000 (12:08 +0900)
commitf755ecfb8cec7b19dff84295309f2afb24a5afd1
tree0786fec1e825368514b8db02c53ab31acb66505b
parent353169acf1858bb2dc3f91475dafabce547de14c
powerpc/pseries: Correct string length in pseries_of_derive_parent()

Commit a030e1e4bbd085bbcfd0a23f8d355fcd41f39bed make a change to use
kstrndup() instead of kmalloc() + strlcpy() in the pseries_of_derive_parent()
routine that introduces a subtle change in the parent path name generated.
The kstrndup() routine will copy n characters followed by a terminating null,
whereas strlcpy() will copy n-1 characters and add a terminating null.

This slight difference results in having a parent path that includes the
tailing '/' character, "/cpus/" vs. "/cpus". This then causes the subsequent
call to of_find_node_by_path() to fail, and in the case of DLPAR add
operations the DLPAR request fails.

This patch decrements the pointer returned from kbasename() to point to the
'/' character before the base name instead of the base name. This then
adjusts the string length calculations to not include the trailing '/'
in the parent path name.

Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/platforms/pseries/of_helpers.c