projects / firefly-linux-kernel-4.4.55.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: dff8817) | patch
ide: remove superfluous SELECT_MASK() call from ide_driveid_update()
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Sun, 7 Jun 2009 13:37:06 +0000 (15:37 +0200)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Sun, 7 Jun 2009 13:37:06 +0000 (15:37 +0200)
commitf9952beeaa851f7f79a4dd895bfed3f3ff6deebc
treed1ab68325300fb7bc6fbfb86c09cb3e76d5814e9tree | snapshot
parentdff8817b78e6e6a4913f2caf7637d62dcc49a03ccommit | diff
ide: remove superfluous SELECT_MASK() call from ide_driveid_update()

We always call SELECT_MASK(drive, 0) after ide_dev_read_id() call
so there is no need to do it again in the error path.

Moreover with the combination of HPT36x controller and the drive on
the quirk_drives[] list this can result in superfluous enable_irq()
call which in turn will trigger WARN() in __enable_irq().

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/ide/ide-iops.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.