ALSA: fm801: Fix double free in case of error in tuner detection
authorBen Hutchings <ben@decadent.org.uk>
Thu, 22 Sep 2011 13:38:58 +0000 (14:38 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 3 Oct 2011 18:41:03 +0000 (11:41 -0700)
commitf9db06c630f31bc26d4946151aa8db5aa4155c96
treec56910fd567d61956c6db8a7309345180ac58179
parentb5fa99b753a2b03aeb9ce2851ac038855258e847
ALSA: fm801: Fix double free in case of error in tuner detection

commit 2ba34e43ba0469086d1ff81c13a9aa9070c1a0e1 upstream.

Commit 9676001559fce06e37c7dc230ab275f605556176
("ALSA: fm801: add error handling if auto-detect fails") added
incorrect error handling.

Once we have successfully called snd_device_new(), the cleanup
function fm801_free() will automatically be called by snd_card_free()
and we must *not* also call fm801_free() directly.

Reported-by: Hor Jiun Shyong <jiunshyong@gmail.com>
References: http://bugs.debian.org/641946
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
sound/pci/fm801.c