dm: set DMF_SUSPENDED* _before_ clearing DMF_NOFLUSH_SUSPENDING
authorMike Snitzer <snitzer@redhat.com>
Tue, 2 Aug 2016 17:07:20 +0000 (13:07 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 20 Aug 2016 16:09:19 +0000 (18:09 +0200)
commitfb76628b66f88b6c8206fa906f524362869b5c03
tree8a88e5dfc599beb11a2387ce75661e8845191d01
parent1fe16eaeb94068fbe002ec75cb4799a2474108fd
dm: set DMF_SUSPENDED* _before_ clearing DMF_NOFLUSH_SUSPENDING

commit eaf9a7361f47727b166688a9f2096854eef60fbe upstream.

Otherwise, there is potential for both DMF_SUSPENDED* and
DMF_NOFLUSH_SUSPENDING to not be set during dm_suspend() -- which is
definitely _not_ a valid state.

This fix, in conjuction with "dm rq: fix the starting and stopping of
blk-mq queues", addresses the potential for request-based DM multipath's
__multipath_map() to see !dm_noflush_suspending() during suspend.

Reported-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/dm.c