Do not mess with NDEBUG in fbstring
authorGiuseppe Ottaviano <ott@fb.com>
Mon, 12 Sep 2016 21:00:40 +0000 (14:00 -0700)
committerFacebook Github Bot 7 <facebook-github-bot-7-bot@fb.com>
Mon, 12 Sep 2016 21:08:32 +0000 (14:08 -0700)
commitfd01e2bfa6a9ca0cfe3f3317ccc66173c683c769
treed53cc109e33a9ce9bf63bb1735e057f6a832f1d5
parent6a6ac91e1fda65d7871390f03be8d19b3591ba45
Do not mess with NDEBUG in fbstring

Summary: Temporarily overriding `NDEBUG` can have unexpected side-effects depending on the implementation of `<assert.h>`. Better use an explicit macro for `assert()` that we can explicitly disable.

Reviewed By: Gownta

Differential Revision: D3850717

fbshipit-source-id: b1e7fce89ab4120b0224e9c6bf668d983b3d2d31
folly/FBString.h