netdev notifier are not unregistered if pci_register_driver fails.
Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
static int __init qlcnic_init_module(void)
{
static int __init qlcnic_init_module(void)
{
printk(KERN_INFO "%s\n", qlcnic_driver_string);
printk(KERN_INFO "%s\n", qlcnic_driver_string);
register_inetaddr_notifier(&qlcnic_inetaddr_cb);
#endif
register_inetaddr_notifier(&qlcnic_inetaddr_cb);
#endif
+ ret = pci_register_driver(&qlcnic_driver);
+ if (ret) {
+#ifdef CONFIG_INET
+ unregister_inetaddr_notifier(&qlcnic_inetaddr_cb);
+ unregister_netdevice_notifier(&qlcnic_netdev_cb);
+#endif
+ }
- return pci_register_driver(&qlcnic_driver);
}
module_init(qlcnic_init_module);
}
module_init(qlcnic_init_module);