Right now we have some trouble with non atomic access
to page flags when locking the page. To plug this hole
for now, limit error recovery to LRU pages for now.
This could be better fixed by defining a suitable protocol,
but let's go this simple way for now
This avoids unnecessary races with __set_page_locked() and
__SetPageSlab*() and maybe more non-atomic page flag operations.
This loses isolated pages which are currently in page reclaim, but these
are relatively limited compared to the total memory.
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
[AK: new description, bug fixes, cleanups]
int ret = FAILED;
struct address_space *mapping;
int ret = FAILED;
struct address_space *mapping;
- if (!isolate_lru_page(p))
- page_cache_release(p);
-
/*
* For anonymous pages we're done the only reference left
* should be the one m_f() holds.
/*
* For anonymous pages we're done the only reference left
* should be the one m_f() holds.
*/
static int me_swapcache_dirty(struct page *p, unsigned long pfn)
{
*/
static int me_swapcache_dirty(struct page *p, unsigned long pfn)
{
ClearPageDirty(p);
/* Trigger EIO in shmem: */
ClearPageUptodate(p);
ClearPageDirty(p);
/* Trigger EIO in shmem: */
ClearPageUptodate(p);
- if (!isolate_lru_page(p)) {
- page_cache_release(p);
- ret = DELAYED;
- }
-
- return ret;
}
static int me_swapcache_clean(struct page *p, unsigned long pfn)
{
}
static int me_swapcache_clean(struct page *p, unsigned long pfn)
{
- int ret = FAILED;
-
- if (!isolate_lru_page(p)) {
- page_cache_release(p);
- ret = RECOVERED;
- }
delete_from_swap_cache(p);
delete_from_swap_cache(p);
{ 0, 0, "unknown page state", me_unknown },
};
{ 0, 0, "unknown page state", me_unknown },
};
static void action_result(unsigned long pfn, char *msg, int result)
{
struct page *page = NULL;
static void action_result(unsigned long pfn, char *msg, int result)
{
struct page *page = NULL;
if (PageReserved(p) || PageCompound(p) || PageSlab(p))
return;
if (PageReserved(p) || PageCompound(p) || PageSlab(p))
return;
- if (!PageLRU(p))
- lru_add_drain_all();
-
/*
* This check implies we don't kill processes if their pages
* are in the swap cache early. Those are always late kills.
/*
* This check implies we don't kill processes if their pages
* are in the swap cache early. Those are always late kills.
int __memory_failure(unsigned long pfn, int trapno, int ref)
{
int __memory_failure(unsigned long pfn, int trapno, int ref)
{
+ unsigned long lru_flag;
struct page_state *ps;
struct page *p;
int res;
struct page_state *ps;
struct page *p;
int res;
return PageBuddy(compound_head(p)) ? 0 : -EBUSY;
}
return PageBuddy(compound_head(p)) ? 0 : -EBUSY;
}
+ /*
+ * We ignore non-LRU pages for good reasons.
+ * - PG_locked is only well defined for LRU pages and a few others
+ * - to avoid races with __set_page_locked()
+ * - to avoid races with __SetPageSlab*() (and more non-atomic ops)
+ * The check (unnecessarily) ignores LRU pages being isolated and
+ * walked by the page reclaim code, however that's not a big loss.
+ */
+ if (!PageLRU(p))
+ lru_add_drain_all();
+ lru_flag = p->flags & lru;
+ if (isolate_lru_page(p)) {
+ action_result(pfn, "non LRU", IGNORED);
+ put_page(p);
+ return -EBUSY;
+ }
+ page_cache_release(p);
+
/*
* Lock the page and wait for writeback to finish.
* It's very difficult to mess with pages currently under IO
/*
* Lock the page and wait for writeback to finish.
* It's very difficult to mess with pages currently under IO
/*
* Torn down by someone else?
*/
/*
* Torn down by someone else?
*/
- if (PageLRU(p) && !PageSwapCache(p) && p->mapping == NULL) {
+ if ((lru_flag & lru) && !PageSwapCache(p) && p->mapping == NULL) {
action_result(pfn, "already truncated LRU", IGNORED);
res = 0;
goto out;
action_result(pfn, "already truncated LRU", IGNORED);
res = 0;
goto out;
res = -EBUSY;
for (ps = error_states;; ps++) {
res = -EBUSY;
for (ps = error_states;; ps++) {
- if ((p->flags & ps->mask) == ps->res) {
+ if (((p->flags | lru_flag)& ps->mask) == ps->res) {
res = page_action(ps, p, pfn, ref);
break;
}
res = page_action(ps, p, pfn, ref);
break;
}