Fix infinite loop if sn_hwperf_location_to_bpos() fails.
Signed-off-by: Mark Goodwin <markgw@sgi.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
* PCI busses attached to this node, if any
*/
do {
* PCI busses attached to this node, if any
*/
do {
- if (!(pci_topo_buf = vmalloc(pci_topo_buf_len))) {
- printk("sn_topology_show: kmalloc failed\n");
+ if (sn_hwperf_location_to_bpos(obj->location,
+ &rack, &bay, &slot, &slab)) {
- if (sn_hwperf_location_to_bpos(obj->location,
- &rack, &bay, &slot, &slab) != 0)
- continue;
+ if (!(pci_topo_buf = vmalloc(pci_topo_buf_len))) {
+ printk("sn_topology_show: vmalloc failed\n");
+ break;
+ }
e = ia64_sn_ioif_get_pci_topology(rack, bay, slot, slab,
pci_topo_buf, pci_topo_buf_len);
e = ia64_sn_ioif_get_pci_topology(rack, bay, slot, slab,
pci_topo_buf, pci_topo_buf_len);
break;
case SN_HWPERF_OP_OK:
break;
case SN_HWPERF_OP_OK:
/* export pci bus info */
print_pci_topology(s, obj, &pci_bus_ordinal,
pci_topo_buf, pci_topo_buf_len);
/* export pci bus info */
print_pci_topology(s, obj, &pci_bus_ordinal,
pci_topo_buf, pci_topo_buf_len);