drivers/firmware/iscsi_ibft.c: remove NIPQUAD_FMT, use %pI4
authorJoe Perches <joe@perches.com>
Thu, 14 Jan 2010 16:34:19 +0000 (11:34 -0500)
committerKonrad Rzeszutek Wilk <konrad@kernel.org>
Fri, 26 Feb 2010 21:02:14 +0000 (21:02 +0000)
Convert netmask to __be32 and format it with %pI4

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Konrad Rzeszutek <ketuzsezr@darnok.org>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Cc: Peter Jones <pjones@redhat.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/firmware/iscsi_ibft.c

index 051d1ebbd2876b68db9df2209161b13da7e8d7bb..f82bcdae130be1a2b8dfce439bbd2bffc09535cc 100644 (file)
@@ -381,7 +381,7 @@ static ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
        void *ibft_loc = entry->header;
        char *str = buf;
        char *mac;
-       int val;
+       __be32 val;
 
        if (!nic)
                return 0;
@@ -397,10 +397,8 @@ static ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
                str += sprintf_ipaddr(str, nic->ip_addr);
                break;
        case ibft_eth_subnet_mask:
-               val = ~((1 << (32-nic->subnet_mask_prefix))-1);
-               str += sprintf(str, NIPQUAD_FMT,
-                              (u8)(val >> 24), (u8)(val >> 16),
-                              (u8)(val >> 8), (u8)(val));
+               val = cpu_to_be32(~((1 << (32-nic->subnet_mask_prefix))-1));
+               str += sprintf(str, "%pI4", &val);
                break;
        case ibft_eth_origin:
                str += sprintf(str, "%d\n", nic->origin);