phy: miphy28lp: Convert to devm_kcalloc and fix wrong sizof
authorAxel Lin <axel.lin@ingics.com>
Thu, 5 Mar 2015 01:43:09 +0000 (09:43 +0800)
committerKishon Vijay Abraham I <kishon@ti.com>
Fri, 13 Mar 2015 11:44:37 +0000 (17:14 +0530)
Prefer devm_kcalloc over devm_kzalloc with multiply.
In additional, use sizeof(phy) is incorrect, fix it.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Gabriel Fernandez<gabriel.fernandez@linaro.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/phy-miphy28lp.c

index 4fe1755e3aa86534ee397b28034b554e49c6a2f1..933435214acce1db8895b95cc739138288b3de4b 100644 (file)
@@ -1209,9 +1209,8 @@ static int miphy28lp_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        miphy_dev->nphys = of_get_child_count(np);
-       miphy_dev->phys = devm_kzalloc(&pdev->dev,
-                                      sizeof(phy) * miphy_dev->nphys,
-                                      GFP_KERNEL);
+       miphy_dev->phys = devm_kcalloc(&pdev->dev, miphy_dev->nphys,
+                                      sizeof(*miphy_dev->phys), GFP_KERNEL);
        if (!miphy_dev->phys)
                return -ENOMEM;