staging: comedi: usbduxsigma: remove unnecessary check in usbdux_ai_cmd()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Thu, 23 May 2013 19:53:46 +0000 (12:53 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 May 2013 11:40:54 +0000 (20:40 +0900)
The comedi core verifies that the command chanlist_len is valid for
the subdevice based on the len_chanlist that was setup during the
attach. There is no need to recheck it in the (*cmd) function.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/usbduxsigma.c

index 7fcf30cad8ac697c9c84326b0b631caed9ac1da9..dab1a3cf3fcdca1850d276dfe007d4a6a18e379b 100644 (file)
@@ -818,12 +818,6 @@ static int usbdux_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
        for (i = 0; i < cmd->chanlist_len; i++) {
                chan = CR_CHAN(cmd->chanlist[i]);
                create_adc_command(chan, &muxsg0, &muxsg1);
-               if (i >= NUMCHANNELS) {
-                       dev_err(&this_usbduxsub->interface->dev,
-                               "comedi%d: channel list too long\n",
-                               dev->minor);
-                       break;
-               }
        }
        this_usbduxsub->dux_commands[5] = muxsg0;
        this_usbduxsub->dux_commands[6] = muxsg1;