staging:iio:dac:ad5791: Use correct DAC bit-size
authorLars-Peter Clausen <lars@metafoo.de>
Wed, 19 Oct 2011 15:47:49 +0000 (17:47 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 19 Oct 2011 20:57:00 +0000 (13:57 -0700)
Commit c5b99396 ("staging:iio:dac:ad5791 chan spec conversion.") introduced a
small bug, using storagebits instead of realbits throughout the driver, which
causes the driver to work incorrectly. This patch fixes it.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/iio/dac/ad5791.c

index fbf446d567171d9654c12cc7ddbc4d0f88e781ba..9a76c4311f9f9bd016d7d023dd845972072cfa75 100644 (file)
@@ -234,11 +234,11 @@ static int ad5791_read_raw(struct iio_dev *indio_dev,
                        return ret;
                *val &= AD5791_DAC_MASK;
                *val >>= chan->scan_type.shift;
-               *val -= (1 << (chan->scan_type.storagebits - 1));
+               *val -= (1 << (chan->scan_type.realbits - 1));
                return IIO_VAL_INT;
        case (1 << IIO_CHAN_INFO_SCALE_SHARED):
                *val = 0;
-               *val2 = (st->vref_mv * 1000) >> chan->scan_type.storagebits;
+               *val2 = (st->vref_mv * 1000) >> chan->scan_type.realbits;
                return IIO_VAL_INT_PLUS_MICRO;
        default:
                return -EINVAL;
@@ -257,8 +257,8 @@ static int ad5791_write_raw(struct iio_dev *indio_dev,
 
        switch (mask) {
        case 0:
-               val += (1 << (chan->scan_type.storagebits - 1));
-               val &= AD5791_RES_MASK(chan->scan_type.storagebits);
+               val += (1 << (chan->scan_type.realbits - 1));
+               val &= AD5791_RES_MASK(chan->scan_type.realbits);
                val <<= chan->scan_type.shift;
 
                return ad5791_spi_write(st->spi, chan->address, val);