pinctrl: allocate sizeof(*p) instead of sizeof(struct foo)
authorStephen Warren <swarren@nvidia.com>
Wed, 22 Feb 2012 21:26:00 +0000 (14:26 -0700)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 24 Feb 2012 05:28:56 +0000 (06:28 +0100)
This hopefully makes it harder to take the sizeof the wrong type.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Dong Aisheng <dong.aisheng@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/core.c
drivers/pinctrl/pinmux.c

index 1d5943069a03b67d6f4abbe740336fba5aa2cb23..2cc8f727aedfb02c07ed21bd1f3da72516b74cbe 100644 (file)
@@ -502,7 +502,7 @@ static struct pinctrl *pinctrl_get_locked(struct device *dev, const char *name)
         * mapping, this is what consumers will get when requesting
         * a pin control handle with pinctrl_get()
         */
-       p = kzalloc(sizeof(struct pinctrl), GFP_KERNEL);
+       p = kzalloc(sizeof(*p), GFP_KERNEL);
        if (p == NULL) {
                dev_err(dev, "failed to alloc struct pinctrl\n");
                return ERR_PTR(-ENOMEM);
@@ -726,7 +726,7 @@ static int pinctrl_hog_map(struct pinctrl_dev *pctldev,
        struct pinctrl *p;
        int ret;
 
-       hog = kzalloc(sizeof(struct pinctrl_hog), GFP_KERNEL);
+       hog = kzalloc(sizeof(*hog), GFP_KERNEL);
        if (!hog) {
                dev_err(pctldev->dev, "failed to alloc struct pinctrl_hog\n");
                return -ENOMEM;
@@ -1160,7 +1160,7 @@ struct pinctrl_dev *pinctrl_register(struct pinctrl_desc *pctldesc,
        if (pctldesc->name == NULL)
                return NULL;
 
-       pctldev = kzalloc(sizeof(struct pinctrl_dev), GFP_KERNEL);
+       pctldev = kzalloc(sizeof(*pctldev), GFP_KERNEL);
        if (pctldev == NULL) {
                dev_err(dev, "failed to alloc struct pinctrl_dev\n");
                return NULL;
index 288789750f96eeca1f8f67eb5677da913a34601d..98b89d6cffb071b1c4e43be9706a7b886824d70c 100644 (file)
@@ -491,7 +491,7 @@ static int pinmux_enable_muxmap(struct pinctrl_dev *pctldev,
        p->func_selector = func_selector;
 
        /* Now add this group selector, we may have many of them */
-       grp = kmalloc(sizeof(struct pinmux_group), GFP_KERNEL);
+       grp = kmalloc(sizeof(*grp), GFP_KERNEL);
        if (!grp)
                return -ENOMEM;
        grp->group_selector = group_selector;