[media] ml86v7667: fix compile warning: 'ret' set but not used
authorHans Verkuil <hans.verkuil@cisco.com>
Sun, 30 Jun 2013 07:40:32 +0000 (04:40 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Tue, 3 Sep 2013 12:24:17 +0000 (09:24 -0300)
media_build/v4l/ml86v7667.c: In function 'ml86v7667_s_ctrl':
media_build/v4l/ml86v7667.c:120:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
  int ret;
      ^
And indeed, ret is set but not used. Let's actually return the error
code.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/i2c/ml86v7667.c

index dd1e6c9347f2d8723413af275993225dbfe666c0..a9110d8bbbcd684e691ac63199d6fbb6c1902b95 100644 (file)
@@ -117,7 +117,7 @@ static int ml86v7667_s_ctrl(struct v4l2_ctrl *ctrl)
 {
        struct v4l2_subdev *sd = to_sd(ctrl);
        struct i2c_client *client = v4l2_get_subdevdata(sd);
-       int ret;
+       int ret = -EINVAL;
 
        switch (ctrl->id) {
        case V4L2_CID_BRIGHTNESS:
@@ -157,7 +157,7 @@ static int ml86v7667_s_ctrl(struct v4l2_ctrl *ctrl)
                break;
        }
 
-       return 0;
+       return ret;
 }
 
 static int ml86v7667_querystd(struct v4l2_subdev *sd, v4l2_std_id *std)