Revert "AHCI: Do not acquire ata_host::lock from single IRQ handler"
authorTejun Heo <tj@kernel.org>
Mon, 27 Oct 2014 16:00:01 +0000 (12:00 -0400)
committerTejun Heo <tj@kernel.org>
Mon, 27 Oct 2014 16:00:01 +0000 (12:00 -0400)
This reverts commit 33fb0d01ce60fe4c0c12c4f0c134c5cdb818ac5a.

18dcf433f3de ("AHCI: Optimize single IRQ interrupt processing") is
scheduled to be reverted.  This is an optimization dependent on the
mentioned commit.  Revert it first.

Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/libahci.c

index 5eb61c9e63da95cbd24a54ee0604262288c8a9f6..3ce3d23e4f97cca458b3c3b2b4329c485a6236f2 100644 (file)
@@ -1875,6 +1875,8 @@ static irqreturn_t ahci_single_irq_intr(int irq, void *dev_instance)
 
        irq_masked = irq_stat & hpriv->port_map;
 
+       spin_lock(&host->lock);
+
        for (i = 0; i < host->n_ports; i++) {
                struct ata_port *ap;
 
@@ -1906,6 +1908,8 @@ static irqreturn_t ahci_single_irq_intr(int irq, void *dev_instance)
         */
        writel(irq_stat, mmio + HOST_IRQ_STAT);
 
+       spin_unlock(&host->lock);
+
        VPRINTK("EXIT\n");
 
        return handled ? IRQ_WAKE_THREAD : IRQ_NONE;