[media] em28xx: ensure "closing" messages terminate with a newline
authorRussell King <rmk+kernel@arm.linux.org.uk>
Sat, 20 Dec 2014 12:45:20 +0000 (09:45 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 23 Dec 2014 16:46:03 +0000 (14:46 -0200)
The lockdep splat addressed in a previous commit revealed that at
least one message in em28xx-input.c was missing a new line:

em28178 #0: Closing input extensionINFO: trying to register non-static key.

Further inspection shows several other messages also miss a new line.
These will be fixed in a subsequent patch.

Fixes: aa929ad783c0 ("[media] em28xx: print a message at disconnect")
Cc: <stable@vger.kernel.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Reviewed-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/usb/em28xx/em28xx-audio.c
drivers/media/usb/em28xx/em28xx-dvb.c
drivers/media/usb/em28xx/em28xx-input.c
drivers/media/usb/em28xx/em28xx-video.c

index 44ae1e0661e6edcc64a1ef173eb6b60c48005801..52dc9d70da7296da1dd058487b957a40e467a3c9 100644 (file)
@@ -981,7 +981,7 @@ static int em28xx_audio_fini(struct em28xx *dev)
                return 0;
        }
 
-       em28xx_info("Closing audio extension");
+       em28xx_info("Closing audio extension\n");
 
        if (dev->adev.sndcard) {
                snd_card_disconnect(dev->adev.sndcard);
index 9877b699c6bccc864c17f23ae52e65e782802372..80c384c390e2516281c859c09bf4562f8064d8d0 100644 (file)
@@ -1724,7 +1724,7 @@ static int em28xx_dvb_fini(struct em28xx *dev)
        if (!dev->dvb)
                return 0;
 
-       em28xx_info("Closing DVB extension");
+       em28xx_info("Closing DVB extension\n");
 
        dvb = dev->dvb;
        client = dvb->i2c_client_tuner;
index ef36c49ef166595c35489808e44a2b7974275a29..aea22deadc0a60b33f4f1dff35653920ba0e28f6 100644 (file)
@@ -832,7 +832,7 @@ static int em28xx_ir_fini(struct em28xx *dev)
                return 0;
        }
 
-       em28xx_info("Closing input extension");
+       em28xx_info("Closing input extension\n");
 
        em28xx_shutdown_buttons(dev);
 
index 3691b39424bede7663886f614397c76ccdda2e86..eeb4ad5a3a768d4ce540bbd091a71eba3841b6d5 100644 (file)
@@ -1958,7 +1958,7 @@ static int em28xx_v4l2_fini(struct em28xx *dev)
        if (v4l2 == NULL)
                return 0;
 
-       em28xx_info("Closing video extension");
+       em28xx_info("Closing video extension\n");
 
        mutex_lock(&dev->lock);