[media] gspca - stv06xx: Fix a regression with the bridge/sensor vv6410
authorJean-François Moine <moinejf@free.fr>
Thu, 22 Nov 2012 11:59:06 +0000 (08:59 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 21 Dec 2012 14:40:20 +0000 (12:40 -0200)
Setting the H and V flip controls at webcam connection time prevents
the webcam to work correctly.
This patch checks if the webcam is streaming before setting the flips.
It does not set the flips (nor other controls) at webcam start time.

Tested-by: Philippe ROUBACH <philippe.roubach@free.fr>
Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c

index 748e1421d6d8c93bdb993c1aaf32d09d8297fca2..cbb153180d59062523b43f6cbc07d6fffa96dbd8 100644 (file)
@@ -52,9 +52,13 @@ static int vv6410_s_ctrl(struct v4l2_ctrl *ctrl)
 
        switch (ctrl->id) {
        case V4L2_CID_HFLIP:
+               if (!gspca_dev->streaming)
+                       return 0;
                err = vv6410_set_hflip(gspca_dev, ctrl->val);
                break;
        case V4L2_CID_VFLIP:
+               if (!gspca_dev->streaming)
+                       return 0;
                err = vv6410_set_vflip(gspca_dev, ctrl->val);
                break;
        case V4L2_CID_GAIN: