net-ipvlan: Deletion of an unnecessary check before the function call "free_percpu"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 29 Nov 2014 15:23:20 +0000 (16:23 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 6 Dec 2014 05:14:20 +0000 (21:14 -0800)
The free_percpu() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Mahesh Bandewar <maheshb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ipvlan/ipvlan_main.c

index 96b71b0d78f6552a5af2518247562d11dd276fd5..feb185389a87ed03cf24449dcf3b3121d72e5108 100644 (file)
@@ -125,8 +125,7 @@ static void ipvlan_uninit(struct net_device *dev)
        struct ipvl_dev *ipvlan = netdev_priv(dev);
        struct ipvl_port *port = ipvlan->port;
 
-       if (ipvlan->pcpu_stats)
-               free_percpu(ipvlan->pcpu_stats);
+       free_percpu(ipvlan->pcpu_stats);
 
        port->count -= 1;
        if (!port->count)