re-enable direct calls, this should just be a performance boost
authorDuraid Madina <duraid@octopus.com.au>
Fri, 20 May 2005 11:39:17 +0000 (11:39 +0000)
committerDuraid Madina <duraid@octopus.com.au>
Fri, 20 May 2005 11:39:17 +0000 (11:39 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@22148 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Target/IA64/IA64ISelPattern.cpp

index 1ea16cce8f4153ac5efeddd36989ddf2c29284a6..2e34b36715f6d1a405be972ec6456e0163b4a201 100644 (file)
@@ -2151,16 +2151,13 @@ pC = pA OR pB
         }
       }
 
-      /*  XXX we want to re-enable direct branches! crippling them now
-       *  to stress-test indirect branches.:
-    //build the right kind of call
+    // build the right kind of call. if we can branch directly, do so:
     if (GlobalAddressSDNode *GASD =
                dyn_cast<GlobalAddressSDNode>(N.getOperand(1)))
       {
         BuildMI(BB, IA64::BRCALL, 1).addGlobalAddress(GASD->getGlobal(),true);
         IA64Lowering.restoreGP_SP_RP(BB);
-      }
-             ^^^^^^^^^^^^^ we want this code one day XXX */
+      } else
     if (ExternalSymbolSDNode *ESSDN =
              dyn_cast<ExternalSymbolSDNode>(N.getOperand(1)))
       { // FIXME : currently need this case for correctness, to avoid
@@ -2169,7 +2166,9 @@ pC = pA OR pB
           .addExternalSymbol(ESSDN->getSymbol(), true);
         IA64Lowering.restoreGP_SP_RP(BB);
       }
-    else {
+    else { // otherwise we need to get the function descriptor
+           // load the branch target (function)'s entry point and
+          // GP, then branch
       Tmp1 = SelectExpr(N.getOperand(1));
 
       unsigned targetEntryPoint=MakeReg(MVT::i64);