drm/fb-helper: Do the 'max_conn_count' zero check
authorXiubo Li <Li.Xiubo@freescale.com>
Mon, 10 Mar 2014 01:33:58 +0000 (09:33 +0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 17 Mar 2014 10:23:08 +0000 (11:23 +0100)
Since we cannot make sure the 'max_conn_count' will always be none
zero from the users, and then if max_conn_count equals to zero, the
kcalloc() will return ZERO_SIZE_PTR, which equals to ((void *)16).

So this patch fix this with just doing the 'max_conn_count' zero check
in the front of drm_fb_helper_init().

Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
CC: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/drm_fb_helper.c

index e5208e072ac7de7d3001f3b0e75d4983d2303372..89382dce1d5935769938b5daa269cb99bb8f482e 100644 (file)
@@ -516,6 +516,9 @@ int drm_fb_helper_init(struct drm_device *dev,
        struct drm_crtc *crtc;
        int i;
 
+       if (!max_conn_count)
+               return -EINVAL;
+
        fb_helper->dev = dev;
 
        INIT_LIST_HEAD(&fb_helper->kernel_fb_list);