perf tools: Remove usage of trace_sched_wakeup(.success)
authorPeter Zijlstra <peterz@infradead.org>
Mon, 12 May 2014 18:19:46 +0000 (20:19 +0200)
committerJiri Olsa <jolsa@kernel.org>
Mon, 12 May 2014 19:13:44 +0000 (21:13 +0200)
trace_sched_wakeup(.success) is a dead argument and has been for ages,
the only reason its still there is because of brain dead software, which
apparently includes perf tools

There's a few more instances in pearly snake shit, but that's not
supported as far as I care anyhow, so let that bitrot.

Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20140512181946.GG13467@laptop.programming.kicks-ass.net
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
tools/perf/builtin-sched.c
tools/perf/tests/evsel-tp-sched.c

index 2579215f57433e06028caed439914b28c3ca0a7b..a3320f1cda694b94784df75d7402840aa3898189 100644 (file)
@@ -1007,17 +1007,12 @@ static int latency_wakeup_event(struct perf_sched *sched,
                                struct perf_sample *sample,
                                struct machine *machine)
 {
-       const u32 pid     = perf_evsel__intval(evsel, sample, "pid"),
-                 success = perf_evsel__intval(evsel, sample, "success");
+       const u32 pid     = perf_evsel__intval(evsel, sample, "pid");
        struct work_atoms *atoms;
        struct work_atom *atom;
        struct thread *wakee;
        u64 timestamp = sample->time;
 
-       /* Note for later, it may be interesting to observe the failing cases */
-       if (!success)
-               return 0;
-
        wakee = machine__findnew_thread(machine, 0, pid);
        atoms = thread_atoms_search(&sched->atom_root, wakee, &sched->cmp_pid);
        if (!atoms) {
index 4774f7fbb75899c9b654962192fc1dd314253fe0..35d7fdb2328db7a3bcc8d33070c1e68aaa7f858e 100644 (file)
@@ -74,9 +74,6 @@ int test__perf_evsel__tp_sched_test(void)
        if (perf_evsel__test_field(evsel, "prio", 4, true))
                ret = -1;
 
-       if (perf_evsel__test_field(evsel, "success", 4, true))
-               ret = -1;
-
        if (perf_evsel__test_field(evsel, "target_cpu", 4, true))
                ret = -1;