Defensively guard against calling malloc() with a size of zero.
authorTed Kremenek <kremenek@apple.com>
Thu, 26 Apr 2012 20:54:27 +0000 (20:54 +0000)
committerTed Kremenek <kremenek@apple.com>
Thu, 26 Apr 2012 20:54:27 +0000 (20:54 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@155661 91177308-0d34-0410-b5e6-96231b3b80d8

runtime/libprofile/CommonProfiling.c

index d55f51c5b44ab698552afa395c81f92b29dee531..13e3eb9cf7bdb953e7a7ca9fd5da976415a2ce52 100644 (file)
@@ -65,6 +65,15 @@ int save_arguments(int argc, const char **argv) {
   for (Length = 0, i = 0; i != (unsigned)argc; ++i)
     Length += strlen(argv[i])+1;
 
+  // Defensively check for a zero length, even though this is unlikely
+  // to happen in practice.  This avoids calling malloc() below with a
+  // size of 0.
+  if (Length == 0) {
+    SavedArgs = 0;
+    SavedArgsLength = 0;
+    return argc;
+  }
+  
   SavedArgs = (char*)malloc(Length);
   for (Length = 0, i = 0; i != (unsigned)argc; ++i) {
     unsigned Len = strlen(argv[i]);