V4L/DVB: hdpvr: Fixes probing function
authorPerceval Anichini <perceval@trilogic.fr>
Mon, 5 Jul 2010 18:11:51 +0000 (15:11 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 2 Aug 2010 18:28:34 +0000 (15:28 -0300)
In the hdpvr_probe () function, when an error occurs while probing the device,
the workqueue created by the create_single_thread () call is not properly
destroyed.

Signed-off-by: Perceval Anichini <perceval@trilogic.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/hdpvr/hdpvr-core.c

index 830d47b05e1dba6f97520613e0299d217125cb67..0cae5b82e1a2e6eb84859dc4c49de40ef68ec5e3 100644 (file)
@@ -286,6 +286,8 @@ static int hdpvr_probe(struct usb_interface *interface,
                goto error;
        }
 
+       dev->workqueue = 0;
+
        /* register v4l2_device early so it can be used for printks */
        if (v4l2_device_register(&interface->dev, &dev->v4l2_dev)) {
                err("v4l2_device_register failed");
@@ -380,6 +382,9 @@ static int hdpvr_probe(struct usb_interface *interface,
 
 error:
        if (dev) {
+               /* Destroy single thread */
+               if (dev->workqueue)
+                       destroy_workqueue(dev->workqueue);
                /* this frees allocated memory */
                hdpvr_delete(dev);
        }