megaraid_sas : Use writeq for 64bit pci write to avoid spinlock overhead
authorSumit.Saxena@avagotech.com <Sumit.Saxena@avagotech.com>
Fri, 12 Sep 2014 13:27:18 +0000 (18:57 +0530)
committerChristoph Hellwig <hch@lst.de>
Tue, 16 Sep 2014 16:14:22 +0000 (09:14 -0700)
Resending the patch. Addressed the review comments from Tomas Henzl.
Reduce the assingment for u64 req_data variable.

Use writeq() for 64bit PCI write instead of writel() to avoid additional lock overhead.

Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
Signed-off-by: Kashyap Desai <kashyap.desai@avagotech.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/megaraid/megaraid_sas_fusion.c

index 57b47fe6907241224b6be45a73999221191e34f4..8898817eaf8b30562b15f4e554f94cbca127ef41 100644 (file)
@@ -1065,6 +1065,11 @@ megasas_fire_cmd_fusion(struct megasas_instance *instance,
                        u32 req_desc_hi,
                        struct megasas_register_set __iomem *regs)
 {
+#if defined(writeq) && defined(CONFIG_64BIT)
+       u64 req_data = (((u64)req_desc_hi << 32) | (u32)req_desc_lo);
+
+       writeq(le64_to_cpu(req_data), &(regs)->inbound_low_queue_port);
+#else
        unsigned long flags;
 
        spin_lock_irqsave(&instance->hba_lock, flags);
@@ -1072,6 +1077,7 @@ megasas_fire_cmd_fusion(struct megasas_instance *instance,
        writel(le32_to_cpu(req_desc_lo), &(regs)->inbound_low_queue_port);
        writel(le32_to_cpu(req_desc_hi), &(regs)->inbound_high_queue_port);
        spin_unlock_irqrestore(&instance->hba_lock, flags);
+#endif
 }
 
 /**