mmc: core: Remove unnecessary check for the remove callback
authorUlf Hansson <ulf.hansson@linaro.org>
Mon, 10 Jun 2013 15:03:36 +0000 (17:03 +0200)
committerlintao <lintao@rock-chips.com>
Fri, 7 Mar 2014 04:54:56 +0000 (12:54 +0800)
For every bus_ops type the .remove callback always exist, thus there
are no need to check the existence of it, before we decide to call it.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Tested-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Chris Ball <cjb@laptop.org>
drivers/mmc/core/core.c

index d01ec08291423bd9e8f14a1567e9449f5fb13e8d..e182ad8a33ac893e9f0acc7160452a9a662ed8dd 100644 (file)
@@ -2546,9 +2546,7 @@ void mmc_stop_host(struct mmc_host *host)
        mmc_bus_get(host);
        if (host->bus_ops && !host->bus_dead) {
                /* Calling bus_ops->remove() with a claimed host can deadlock */
-               if (host->bus_ops->remove)
-                       host->bus_ops->remove(host);
-
+               host->bus_ops->remove(host);
                mmc_claim_host(host);
                mmc_detach_bus(host);
                mmc_power_off(host);
@@ -2705,8 +2703,7 @@ int mmc_suspend_host(struct mmc_host *host)
                         * bus_ops->remove() with a claimed host can
                         * deadlock.)
                         */
-                       if (host->bus_ops->remove)
-                               host->bus_ops->remove(host);
+                       host->bus_ops->remove(host);
                        mmc_claim_host(host);
                        mmc_detach_bus(host);
                        mmc_power_off(host);
@@ -2800,9 +2797,7 @@ int mmc_pm_notify(struct notifier_block *notify_block,
                        break;
 
                /* Calling bus_ops->remove() with a claimed host can deadlock */
-               if (host->bus_ops->remove)
-                       host->bus_ops->remove(host);
-
+               host->bus_ops->remove(host);
                mmc_claim_host(host);
                mmc_detach_bus(host);
                mmc_power_off(host);