iio: dac: ad5504: Don't set error code to voltage_uv
authorAxel Lin <axel.lin@ingics.com>
Fri, 14 Dec 2012 12:06:00 +0000 (12:06 +0000)
committerJonathan Cameron <jic23@kernel.org>
Thu, 27 Dec 2012 11:00:16 +0000 (11:00 +0000)
regulator_get_voltage() may return negative error code.
Add error checking to avoid setting error code to voltage_uv.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/dac/ad5504.c

index 242bdc7d004492616e20cff52c98702ec5b928d0..7f7c026b9d8a8eb58a63d369b8441ac57a152389 100644 (file)
@@ -296,7 +296,11 @@ static int __devinit ad5504_probe(struct spi_device *spi)
                if (ret)
                        goto error_put_reg;
 
-               voltage_uv = regulator_get_voltage(reg);
+               ret = regulator_get_voltage(reg);
+               if (ret < 0)
+                       goto error_disable_reg;
+
+               voltage_uv = ret;
        }
 
        spi_set_drvdata(spi, indio_dev);