udf: Deletion of unnecessary checks before the function call "iput"
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 18 Nov 2014 16:17:46 +0000 (17:17 +0100)
committerJan Kara <jack@suse.cz>
Wed, 19 Nov 2014 20:55:45 +0000 (21:55 +0100)
The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/udf/super.c

index e229315bbf7adab01933827a68b59ccb8831dec7..f93c65d6c7d9322e47da2b6fd2df805692d4b83f 100644 (file)
@@ -2237,8 +2237,7 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
        return 0;
 
 error_out:
-       if (sbi->s_vat_inode)
-               iput(sbi->s_vat_inode);
+       iput(sbi->s_vat_inode);
 #ifdef CONFIG_UDF_NLS
        if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP))
                unload_nls(sbi->s_nls_map);
@@ -2291,8 +2290,7 @@ static void udf_put_super(struct super_block *sb)
 
        sbi = UDF_SB(sb);
 
-       if (sbi->s_vat_inode)
-               iput(sbi->s_vat_inode);
+       iput(sbi->s_vat_inode);
 #ifdef CONFIG_UDF_NLS
        if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP))
                unload_nls(sbi->s_nls_map);