Switch SROA to pop Uses off the back of its visitors' queues.

This will more closely match the behavior of the new PtrUseVisitor that
I am adding. Hopefully this will not change the actual behavior in any
way, but by making the processing order more similar help in debugging.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@169697 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Transforms/Scalar/SROA.cpp b/lib/Transforms/Scalar/SROA.cpp
index cb9838ef67443ed1dc79e482ebaf04db0cacc840..a4b8b47a6745d875fffed011a91fc85e8ceb5a87 100644 (file)
--- a/lib/Transforms/Scalar/SROA.cpp
+++ b/lib/Transforms/Scalar/SROA.cpp
@@ -522,11 +522,10 @@ public:
 
   /// \brief Run the builder over the allocation.
   bool operator()() {
-    // Note that we have to re-evaluate size on each trip through the loop as
-    // the queue grows at the tail.
-    for (unsigned Idx = 0; Idx < Queue.size(); ++Idx) {
-      U = Queue[Idx].U;
-      Offset = Queue[Idx].Offset;
+    while (!Queue.empty()) {
+      U = Queue.back().U;
+      Offset = Queue.back().Offset;
+      Queue.pop_back();
       if (!visit(cast<Instruction>(U->getUser())))
         return false;
     }
@@ -851,11 +850,10 @@ public:
 
   /// \brief Run the builder over the allocation.
   void operator()() {
-    // Note that we have to re-evaluate size on each trip through the loop as
-    // the queue grows at the tail.
-    for (unsigned Idx = 0; Idx < Queue.size(); ++Idx) {
-      U = Queue[Idx].U;
-      Offset = Queue[Idx].Offset;
+    while (!Queue.empty()) {
+      U = Queue.back().U;
+      Offset = Queue.back().Offset;
+      Queue.pop_back();
       this->visit(cast<Instruction>(U->getUser()));
     }
   }