iwmc3200wifi: remove setting WEP keys before setting essid support
authorZhu Yi <yi.zhu@intel.com>
Thu, 16 Jul 2009 09:34:11 +0000 (17:34 +0800)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 24 Jul 2009 19:05:21 +0000 (15:05 -0400)
The recent cfg80211 "rework key operation" patch from Johannes Berg
makes sure keys are set only after the connection has been
established. So we can remove the setting WEP keys before essid
support from the driver.

Signed-off-by: Zhu Yi <yi.zhu@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/iwmc3200wifi/cfg80211.c

index ee403176438960bdc3fb53ecc59586956b55405e..0372658bac99c4e10be5261918b3b1c9db1637a7 100644 (file)
@@ -203,32 +203,6 @@ static int iwm_cfg80211_add_key(struct wiphy *wiphy, struct net_device *ndev,
                return ret;
        }
 
-       /*
-        * The WEP keys can be set before or after setting the essid.
-        * We need to handle both cases by simply pushing the keys after
-        * we send the profile.
-        * If the profile is not set yet (i.e. we're pushing keys before
-        * the essid), we set the cipher appropriately.
-        * If the profile is set, we havent associated yet because our
-        * cipher was incorrectly set. So we invalidate and send the
-        * profile again.
-        */
-       if (key->cipher == WLAN_CIPHER_SUITE_WEP40 ||
-           key->cipher == WLAN_CIPHER_SUITE_WEP104) {
-               u8 *ucast_cipher = &iwm->umac_profile->sec.ucast_cipher;
-               u8 *mcast_cipher = &iwm->umac_profile->sec.mcast_cipher;
-
-               IWM_DBG_WEXT(iwm, DBG, "WEP key\n");
-
-               if (key->cipher == WLAN_CIPHER_SUITE_WEP40)
-                       *ucast_cipher = *mcast_cipher = UMAC_CIPHER_TYPE_WEP_40;
-               if (key->cipher == WLAN_CIPHER_SUITE_WEP104)
-                       *ucast_cipher = *mcast_cipher =
-                               UMAC_CIPHER_TYPE_WEP_104;
-
-               return iwm_reset_profile(iwm);
-       }
-
        return iwm_set_key(iwm, 0, key);
 }