[PATCH] Voyager: tty locking
authorAlan Cox <alan@lxorguk.ukuu.org.uk>
Tue, 26 Sep 2006 06:32:34 +0000 (23:32 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Tue, 26 Sep 2006 15:48:56 +0000 (08:48 -0700)
Voyager fiddles with current->signal.tty without locking.  It turns out
that the code in question has already cleared current->signal.tty correctly
because daemonize() does the right thing already.

The signal handling also appears to be incorrect as it does an unprotected
sigfillset that also appears unneccessary.  As I don't have a bowtie and am
therefore not a qualified voyager maintainer I leave that to James.

Signed-off-by: Alan Cox <alan@redhat.com>
Acked-by: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
arch/i386/mach-voyager/voyager_thread.c

index 50f6de6ff64dadd20988cf1de715ffb9c76eb863..f39887359e8e86ea8758dc3d2c686a283a9c8590 100644 (file)
@@ -130,7 +130,6 @@ thread(void *unused)
        init_timer(&wakeup_timer);
 
        sigfillset(&current->blocked);
-       current->signal->tty = NULL;
 
        printk(KERN_NOTICE "Voyager starting monitor thread\n");