ALSA: sonicvibes: Remove always NULL parameter
authorLars-Peter Clausen <lars@metafoo.de>
Fri, 2 Jan 2015 11:24:53 +0000 (12:24 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 2 Jan 2015 15:33:52 +0000 (16:33 +0100)
snd_sonicvibes_pcm() take a pointer to a pointer of a PCM where if this
parameter is provided the newly allocated PCM is stored. All callers pass
NULL though, so remove the parameter. This makes the code a bit cleaner and
shorter.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/sonicvibes.c

index 313a7328bf9c884b3a88127a29ef147932246ac0..34cee5c1abd8d447f7820678cc7b304b101e034e 100644 (file)
@@ -880,8 +880,7 @@ static struct snd_pcm_ops snd_sonicvibes_capture_ops = {
        .pointer =      snd_sonicvibes_capture_pointer,
 };
 
-static int snd_sonicvibes_pcm(struct sonicvibes *sonic, int device,
-                             struct snd_pcm **rpcm)
+static int snd_sonicvibes_pcm(struct sonicvibes *sonic, int device)
 {
        struct snd_pcm *pcm;
        int err;
@@ -902,8 +901,6 @@ static int snd_sonicvibes_pcm(struct sonicvibes *sonic, int device,
        snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
                                              snd_dma_pci_data(sonic->pci), 64*1024, 128*1024);
 
-       if (rpcm)
-               *rpcm = pcm;
        return 0;
 }
 
@@ -1491,7 +1488,7 @@ static int snd_sonic_probe(struct pci_dev *pci,
                (unsigned long long)pci_resource_start(pci, 1),
                sonic->irq);
 
-       if ((err = snd_sonicvibes_pcm(sonic, 0, NULL)) < 0) {
+       if ((err = snd_sonicvibes_pcm(sonic, 0)) < 0) {
                snd_card_free(card);
                return err;
        }