Declare Sentinel fragments as mutable to get rid

of some pointless casting. This fragment logically
does not belong to ilist anyway, but to "ghostly"
NodeType.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@65843 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/BasicBlock.h b/include/llvm/BasicBlock.h
index 3ef83e8a816c44a4da169e5ec346a94a29b2abab..54f3690096ecf0be6a9f9d25b0b08b27c4cbba8b 100644 (file)
--- a/include/llvm/BasicBlock.h
+++ b/include/llvm/BasicBlock.h
@@ -38,14 +38,14 @@ template<> struct ilist_traits<Instruction>
     // NodeTy, which becomes the sentinel. Dereferencing the sentinel is
     // forbidden (save the ilist_node<NodeTy>) so no one will ever notice
     // the superposition.
-    return const_cast<Instruction*>(static_cast<const Instruction*>(&Sentinel));
+    return static_cast<Instruction*>(&Sentinel);
   }
   static void destroySentinel(Instruction*) {}
   static iplist<Instruction> &getList(BasicBlock *BB);
   static ValueSymbolTable *getSymTab(BasicBlock *ItemParent);
   static int getListOffset();
 private:
-  ilist_node<Instruction> Sentinel;
+  mutable ilist_node<Instruction> Sentinel;
 };
 
 /// This represents a single basic block in LLVM. A basic block is simply a

diff --git a/include/llvm/Function.h b/include/llvm/Function.h
index 9f4f23be08846d38f5de40a734591b8e8c7be800..37e8f19f6257c0aa13274f7aa2f089bdf0f2f2f1 100644 (file)
--- a/include/llvm/Function.h
+++ b/include/llvm/Function.h
@@ -35,28 +35,28 @@ template<> struct ilist_traits<BasicBlock>
   // createSentinel is used to get hold of the node that marks the end of the
   // list... (same trick used here as in ilist_traits<Instruction>)
   BasicBlock *createSentinel() const {
-    return const_cast<BasicBlock*>(static_cast<const BasicBlock*>(&Sentinel));
+    return static_cast<BasicBlock*>(&Sentinel);
   }
   static void destroySentinel(BasicBlock*) {}
   static iplist<BasicBlock> &getList(Function *F);
   static ValueSymbolTable *getSymTab(Function *ItemParent);
   static int getListOffset();
 private:
-  ilist_node<BasicBlock> Sentinel;
+  mutable ilist_node<BasicBlock> Sentinel;
 };
 
 template<> struct ilist_traits<Argument>
   : public SymbolTableListTraits<Argument, Function> {
 
   Argument *createSentinel() const {
-    return const_cast<Argument*>(static_cast<const Argument*>(&Sentinel));
+    return static_cast<Argument*>(&Sentinel);
   }
   static void destroySentinel(Argument*) {}
   static iplist<Argument> &getList(Function *F);
   static ValueSymbolTable *getSymTab(Function *ItemParent);
   static int getListOffset();
 private:
-  ilist_node<Argument> Sentinel;
+  mutable ilist_node<Argument> Sentinel;
 };
 
 class Function : public GlobalValue, public Annotable,