i40e: do not flush after re-enabling interrupts
authorJesse Brandeburg <jesse.brandeburg@intel.com>
Sat, 28 Sep 2013 07:13:08 +0000 (07:13 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 22 Oct 2013 12:33:43 +0000 (05:33 -0700)
Hot path doesn't need read-flush after interrupt enable, and this
flush really causes a lot of extra cpu utilization.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_main.c
drivers/net/ethernet/intel/i40e/i40e_txrx.c

index fbe7fe2914a9feab9209b0c66025a8ef9eb34169..69ed8014afbd78c699fc513cfeea9453449e7520 100644 (file)
@@ -2560,7 +2560,7 @@ void i40e_irq_dynamic_enable(struct i40e_vsi *vsi, int vector)
              I40E_PFINT_DYN_CTLN_CLEARPBA_MASK |
              (I40E_ITR_NONE << I40E_PFINT_DYN_CTLN_ITR_INDX_SHIFT);
        wr32(hw, I40E_PFINT_DYN_CTLN(vector - 1), val);
-       i40e_flush(hw);
+       /* skip the flush */
 }
 
 /**
@@ -2709,6 +2709,7 @@ static int i40e_vsi_enable_irq(struct i40e_vsi *vsi)
                i40e_irq_dynamic_enable_icr0(pf);
        }
 
+       i40e_flush(&pf->hw);
        return 0;
 }
 
index dc89e72fd0f48401ac5e5f121e9f7566fa67b479..fbc40cd29d23ccbb921d83b1b8a776886f55129c 100644 (file)
@@ -559,8 +559,6 @@ static void i40e_update_dynamic_itr(struct i40e_q_vector *q_vector)
        i40e_set_new_dynamic_itr(&q_vector->tx);
        if (old_itr != q_vector->tx.itr)
                wr32(hw, reg_addr, q_vector->tx.itr);
-
-       i40e_flush(hw);
 }
 
 /**