p54pci: fix serious sparse warning
authorChristian Lamparter <chunkeey@googlemail.com>
Thu, 15 Apr 2010 12:17:07 +0000 (14:17 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 16 Apr 2010 19:32:01 +0000 (15:32 -0400)
This patch fixes a bug which was just recently introduced by
("p54pci: prevent stuck rx-ring on slow system").

make M=drivers/net/wireless/p54 C=2 CF=-D__CHECK_ENDIAN__
  CHECK   drivers/net/wireless/p54/p54pci.c
drivers/net/wireless/p54/p54pci.c:143:11: warning: cast to restricted __le32
  CC [M]  drivers/net/wireless/p54/p54pci.o

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/p54/p54pci.c

index aa29663bf6c9f1c28429a1d47d0349a419ce53da..0a516c8efd20a0c48fe3b805ef4a8045b0db16f4 100644 (file)
@@ -139,7 +139,7 @@ static void p54p_refill_rx_ring(struct ieee80211_hw *dev,
 
        idx = le32_to_cpu(ring_control->host_idx[ring_index]);
        limit = idx;
-       limit -= le32_to_cpu(index);
+       limit -= index;
        limit = ring_limit - limit;
 
        i = idx % ring_limit;