r8169: increase the delay parameter of pm_schedule_suspend
authorhayeswang <hayeswang@realtek.com>
Mon, 7 Nov 2011 20:44:37 +0000 (20:44 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 8 Nov 2011 17:37:06 +0000 (12:37 -0500)
The link down would occur when reseting PHY. And it would take about 2 ~ 5 seconds
from link down to link up. If the delay of pm_schedule_suspend is not long enough,
the device would enter runtime_suspend before link up. After link up, the device
would wake up and reset PHY again. Then, you would find the driver keep in a loop
of runtime_suspend and rumtime_resume.

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169.c

index 92b45f08858fab787a7ac3de3297f9b8c318ea67..6f06aa10f0d729a040a6e34a244d57338ba3025f 100644 (file)
@@ -1292,7 +1292,7 @@ static void __rtl8169_check_link_status(struct net_device *dev,
                netif_carrier_off(dev);
                netif_info(tp, ifdown, dev, "link down\n");
                if (pm)
-                       pm_schedule_suspend(&tp->pci_dev->dev, 100);
+                       pm_schedule_suspend(&tp->pci_dev->dev, 5000);
        }
        spin_unlock_irqrestore(&tp->lock, flags);
 }