eCryptfs: Fix redundant error check on ecryptfs_find_daemon_by_euid()
authorTyler Hicks <tyhicks@canonical.com>
Wed, 27 Feb 2013 19:37:48 +0000 (11:37 -0800)
committerTyler Hicks <tyhicks@canonical.com>
Wed, 27 Feb 2013 19:41:18 +0000 (11:41 -0800)
It is sufficient to check the return code of
ecryptfs_find_daemon_by_euid(). If it returns 0, it always sets the
daemon pointer to point to a valid ecryptfs_daemon.

Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Reported-by: Kees Cook <keescook@chromium.org>
fs/ecryptfs/messaging.c

index d5c7297c5816104236b605cb07261981b8a88293..474051bd8d92f140e81c208ec4761e1f9d4c429e 100644 (file)
@@ -283,7 +283,7 @@ ecryptfs_send_message_locked(char *data, int data_len, u8 msg_type,
        int rc;
 
        rc = ecryptfs_find_daemon_by_euid(&daemon);
-       if (rc || !daemon) {
+       if (rc) {
                rc = -ENOTCONN;
                goto out;
        }