ASoC: ep93xx: Don't set unused struct snd_pcm_hardware fields
authorLars-Peter Clausen <lars@metafoo.de>
Fri, 20 Dec 2013 13:20:11 +0000 (14:20 +0100)
committerMark Brown <broonie@linaro.org>
Mon, 30 Dec 2013 13:59:39 +0000 (13:59 +0000)
The ASoC core assumes that the PCM component of the ASoC card transparently
moves data around and does not impose any restrictions on the memory layout or
the transfer speed. It ignores all fields from the snd_pcm_hardware struct for
the PCM driver that are related to this. Setting these fields in the PCM driver
might suggest otherwise though, so rather not set them.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/cirrus/ep93xx-pcm.c

index ca6698d75736bfba27f806deac3871c5ab2a1c50..5f664471d99ee480fd38bd723e65d8023462973c 100644 (file)
@@ -30,15 +30,6 @@ static const struct snd_pcm_hardware ep93xx_pcm_hardware = {
                                   SNDRV_PCM_INFO_MMAP_VALID    |
                                   SNDRV_PCM_INFO_INTERLEAVED   |
                                   SNDRV_PCM_INFO_BLOCK_TRANSFER),
-                                  
-       .rates                  = SNDRV_PCM_RATE_8000_192000,
-       .rate_min               = SNDRV_PCM_RATE_8000,
-       .rate_max               = SNDRV_PCM_RATE_192000,
-       
-       .formats                = (SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE |
-                                  SNDRV_PCM_FMTBIT_S32_LE),
-       
        .buffer_bytes_max       = 131072,
        .period_bytes_min       = 32,
        .period_bytes_max       = 32768,