btrfs: remove dead code
authorMichal Nazarewicz <mina86@mina86.com>
Fri, 29 Nov 2013 17:01:15 +0000 (18:01 +0100)
committerChris Mason <clm@fb.com>
Tue, 28 Jan 2014 21:19:50 +0000 (13:19 -0800)
[commit 8185554d: fix incorrect inode acl reset] introduced a dead
code by adding a condition which can never be true to an else
branch.  The condition can never be true because it is already
checked by a previous if statement which causes function to return.

Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Reviewed-By: Filipe David Borba Manana <fdmanana@gmail.com>
Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: Chris Mason <clm@fb.com>
fs/btrfs/acl.c

index 0890c83643e944f69e43a22f4151e381e7503f04..460f36bae67259ee64d51670b0ca55f9ec81bcba 100644 (file)
@@ -225,13 +225,8 @@ int btrfs_init_acl(struct btrfs_trans_handle *trans,
                ret = posix_acl_create(&acl, GFP_NOFS, &inode->i_mode);
                if (ret < 0)
                        return ret;
-
-               if (ret > 0) {
-                       /* we need an acl */
+               if (ret > 0) /* we need an acl */
                        ret = btrfs_set_acl(trans, inode, acl, ACL_TYPE_ACCESS);
-               } else if (ret < 0) {
-                       cache_no_acl(inode);
-               }
        } else {
                cache_no_acl(inode);
        }