[media] xc4000: fixed frequency error
authorIstvan Varga <istvan_v@mailbox.hu>
Fri, 3 Jun 2011 15:27:30 +0000 (12:27 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 27 Jul 2011 20:52:34 +0000 (17:52 -0300)
The xc_get_frequency_error() function reported the frequency error
incorrectly. The data read from the hardware is a signed integer, in
15625 Hz units. The attached patch fixes the bug.

Signed-off-by: Istvan Varga <istvan_v@mailbox.hu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/common/tuners/xc4000.c

index be43a6dfac6c41e3d0660d9eebe9259cf6dbf150..f50dd6e713f73fe2f67745ba7b7ea0dbb8e917f4 100644 (file)
@@ -417,8 +417,9 @@ static int xc_get_frequency_error(struct xc4000_priv *priv, u32 *freq_error_hz)
        if (result != XC_RESULT_SUCCESS)
                return result;
 
-       tmp = (u32)regData;
-       (*freq_error_hz) = (tmp * 15625) / 1000;
+       tmp = (u32)regData & 0xFFFFU;
+       tmp = (tmp < 0x8000U ? tmp : 0x10000U - tmp);
+       (*freq_error_hz) = tmp * 15625;
        return result;
 }