Further reduce usage of sys::Path in bugpoint.
authorRafael Espindola <rafael.espindola@gmail.com>
Thu, 13 Jun 2013 16:22:26 +0000 (16:22 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Thu, 13 Jun 2013 16:22:26 +0000 (16:22 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@183912 91177308-0d34-0410-b5e6-96231b3b80d8

tools/bugpoint/ToolRunner.cpp
tools/bugpoint/ToolRunner.h

index 92250418d1bf7ffadd7f43de76fcc8c783420e91..00f14f4fd07491cdd4eed09fd30ced2f0c8b70b4 100644 (file)
@@ -714,8 +714,8 @@ int GCC::ExecuteProgram(const std::string &ProgramFile,
           errs() << " " << GCCArgs[i];
         errs() << "\n";
         );
-  if (RunProgramWithTimeout(GCCPath.str(), &GCCArgs[0], "", "", "")) {
-    *Error = ProcessFailure(GCCPath.str(), &GCCArgs[0]);
+  if (RunProgramWithTimeout(GCCPath, &GCCArgs[0], "", "", "")) {
+    *Error = ProcessFailure(GCCPath, &GCCArgs[0]);
     return -1;
   }
 
@@ -725,7 +725,7 @@ int GCC::ExecuteProgram(const std::string &ProgramFile,
   // ProgramArgs is used.
   std::string Exec;
 
-  if (RemoteClientPath.isEmpty())
+  if (RemoteClientPath.empty())
     ProgramArgs.push_back(OutputBinary.c_str());
   else {
     ProgramArgs.push_back(RemoteClientPath.c_str());
@@ -767,7 +767,7 @@ int GCC::ExecuteProgram(const std::string &ProgramFile,
 
   FileRemover OutputBinaryRemover(OutputBinary.str(), !SaveTemps);
 
-  if (RemoteClientPath.isEmpty()) {
+  if (RemoteClientPath.empty()) {
     DEBUG(errs() << "<run locally>");
     int ExitCode = RunProgramWithTimeout(OutputBinary.str(), &ProgramArgs[0],
                                          InputFile, OutputFile, OutputFile,
@@ -783,7 +783,7 @@ int GCC::ExecuteProgram(const std::string &ProgramFile,
     return ExitCode;
   } else {
     outs() << "<run remotely>"; outs().flush();
-    return RunProgramRemotelyWithTimeout(RemoteClientPath.str(),
+    return RunProgramRemotelyWithTimeout(RemoteClientPath,
         &ProgramArgs[0], InputFile, OutputFile,
         OutputFile, Timeout, MemoryLimit);
   }
@@ -863,8 +863,8 @@ int GCC::MakeSharedObject(const std::string &InputFile, FileType fileType,
           errs() << " " << GCCArgs[i];
         errs() << "\n";
         );
-  if (RunProgramWithTimeout(GCCPath.str(), &GCCArgs[0], "", "", "")) {
-    Error = ProcessFailure(GCCPath.str(), &GCCArgs[0]);
+  if (RunProgramWithTimeout(GCCPath, &GCCArgs[0], "", "", "")) {
+    Error = ProcessFailure(GCCPath, &GCCArgs[0]);
     return 1;
   }
   return 0;
@@ -886,5 +886,5 @@ GCC *GCC::create(std::string &Message,
     RemoteClientPath = sys::FindProgramByName(RemoteClient);
 
   Message = "Found gcc: " + GCCPath.str() + "\n";
-  return new GCC(GCCPath, RemoteClientPath, Args);
+  return new GCC(GCCPath.str(), RemoteClientPath.str(), Args);
 }
index 28c09f5004b6271dcc85e8699e87446b72c2ffa2..8589727753106b11723494c7df90633a0cd80b29 100644 (file)
@@ -38,10 +38,10 @@ class LLC;
 // GCC abstraction
 //
 class GCC {
-  sys::Path GCCPath;                // The path to the gcc executable.
-  sys::Path RemoteClientPath;       // The path to the rsh / ssh executable.
+  std::string GCCPath;                // The path to the gcc executable.
+  std::string RemoteClientPath;       // The path to the rsh / ssh executable.
   std::vector<std::string> gccArgs; // GCC-specific arguments.
-  GCC(const sys::Path &gccPath, const sys::Path &RemotePath,
+  GCC(StringRef gccPath, StringRef RemotePath,
       const std::vector<std::string> *GCCArgs)
     : GCCPath(gccPath), RemoteClientPath(RemotePath) {
     if (GCCArgs) gccArgs = *GCCArgs;